linux-kernel - Re: [PATCH next-20140424] staging/cxt1e1: sparse warning corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 09:05:28 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Sami Laine <laine.j.sami@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	devel <devel@...verdev.osuosl.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, trivial@...nel.org
Subject: Re: [PATCH next-20140424] staging/cxt1e1: sparse warning corrections

Hi,

2014-04-27 0:53 GMT+09:00 Sami Laine <laine.j.sami@...il.com>:
> From: Sami Laine <laine.j.sami@...il.com>
do not include this line on your patch. it is not necessary.
>
> Corrected sparse static declaration warnings.
>
> Signed-off-by: Sami Laine <laine.j.sami@...il.com>
> ---
> diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
> index cc2151e..2899258 100644
> --- a/drivers/staging/cxt1e1/hwprobe.c
> +++ b/drivers/staging/cxt1e1/hwprobe.c
> @@ -40,10 +40,10 @@ struct net_device * __init c4_add_dev(hdw_info_t *, int, unsigned long,
>                                       unsigned long, int, int);
>
>
> -struct s_hdw_info hdw_info[MAX_BOARDS];
> +static struct s_hdw_info hdw_info[MAX_BOARDS];
hdw_info is used in other files with "extern".

>
>
> -void __init
> +static void __init
>  show_two(hdw_info_t *hi, int brdno)
>  {
>         ci_t       *ci;
> @@ -88,7 +88,7 @@ show_two(hdw_info_t *hi, int brdno)
>  }
>
>
> -void __init
> +static void __init
>  hdw_sn_get(hdw_info_t *hi, int brdno)
This function is used in "linux.c"
>  {
>         /* obtain hardware EEPROM information */
> @@ -145,7 +145,7 @@ hdw_sn_get(hdw_info_t *hi, int brdno)
>  }
>
>
> -       void __init
> +static void __init
>  prep_hdw_info(void)
>  {
>         hdw_info_t *hi;
> @@ -164,7 +164,7 @@ prep_hdw_info(void)
>         }
>  }
>
> -void
> +static void
>  cleanup_ioremap(void)
This function is used in "linux.c"
>  {
>         hdw_info_t *hi;
> @@ -187,7 +187,7 @@ cleanup_ioremap(void)
>  }

>
>
> -void
> +static void
>  cleanup_devs(void)
This function is used in "linux.c"

>  {
>         hdw_info_t *hi;
> @@ -287,7 +287,7 @@ c4_hdw_init(struct pci_dev *pdev, int found)
>         return 1;
>  }
>
> -status_t __init
> +static status_t __init
>  c4hw_attach_all(void)
This function is used in "linux.c"

>  {
>         hdw_info_t *hi;

And when you send a patch for this, please check maintainers with "
./scripts/get_maintainer.pl".
In case of this patch, my email is in CC list. :-)

Regards,
Daeseok Youn.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/