linux-kernel - Re: [PATCH] perf tools: Remove extra '/' character in events file path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tx9epawt.fsf@sejong.aot.lge.com>
Date:	Mon, 28 Apr 2014 09:14:58 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	xiakaixu <xiakaixu@...wei.com>
Cc:	<linux-kernel@...r.kernel.org>, <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>, <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Huxinwei <huxinwei@...wei.com>, Genghui <hui.geng@...wei.com>,
	jolsa@...hat.com, bp@...en8.de
Subject: Re: [PATCH] perf tools: Remove extra '/' character in events file path

Hi xiakaixu,

(Adding Jiri and Boris to CC)

> The array debugfs_known_mountpoints[] will cause extra '/'
> character output.
> Remove it.
>
> pre:
> $ perf probe -l
> /sys/kernel/debug//tracing/uprobe_events file does not exist -
> please rebuild kernel with CONFIG_UPROBE_EVENTS.
>
> post:
> $ perf probe -l
> /sys/kernel/debug/tracing/uprobe_events file does not exist -
> please rebuild kernel with CONFIG_UPROBE_EVENTS.

Looks like all of its callers already provide a '/' after the debugfs
mountpoint, so

  Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> 	
> Signed-off-by: Xia Kaixu <xiakaixu@...wei.com>
> ---
>  tools/lib/api/fs/debugfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
> index 7c43479..a74fba6 100644
> --- a/tools/lib/api/fs/debugfs.c
> +++ b/tools/lib/api/fs/debugfs.c
> @@ -12,8 +12,8 @@
>  char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
>
>  static const char * const debugfs_known_mountpoints[] = {
> -	"/sys/kernel/debug/",
> -	"/debug/",
> +	"/sys/kernel/debug",
> +	"/debug",
>  	0,
>  };
>
> -- 1.8.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/