linux-kernel - Re: [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140428145930.GC28443@ulmo>
Date:	Mon, 28 Apr 2014 16:59:31 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	linux-pwm@...r.kernel.org, broonie@...nel.org, swarren@...dia.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage.

On Fri, Mar 21, 2014 at 12:53:09PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
> ---
>  drivers/pwm/pwm-fsl-ftm.c | 83 +++++++++++++++++++++++++----------------------
>  1 file changed, 44 insertions(+), 39 deletions(-)

This could explain the advantages of converting to regmap. Looking at
this diffstat above, it's not immediately obvious that there's an
advantage because you end up adding 5 lines.

Again I'm guessing this is in preparation to add endianess support, and
it will be really easy to add that using regmap, so the gains will only
become obvious later on.

That's the kind of thing I'd like to see in the patch description. It
tells me why this patch makes sense.

Thierry

Content of type "application/pgp-signature" skipped