linux-kernel - Re: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140428150207.GD28443@ulmo>
Date:	Mon, 28 Apr 2014 17:02:08 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	linux-pwm@...r.kernel.org, broonie@...nel.org, swarren@...dia.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support

On Fri, Mar 21, 2014 at 12:53:10PM +0800, Xiubo Li wrote:
> Now for the following scenarios:
> 
>      SoC     |  CPU   | FTM-PWM | 'big-endian' property is needed?
> -------------|--------|---------|---------------------------------
>     Vybird   |  LE    |   LE    |     No
>      LS1     |  LE    |   BE    |     Yes
>      LS2     |  LE    |   LE    |     No
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
> ---
>  drivers/pwm/pwm-fsl-ftm.c | 6 ++++++
>  1 file changed, 6 insertions(+)

And this should probably describe in text what happens. The table may
look good, but you don't give a real description of what the change
does.

Oh, and doesn't this change need to update the device tree binding since
you now have an additional property?

Thierry

Content of type "application/pgp-signature" skipped