linux-kernel - Re: [PATCH v8 02/20] usb: phy: msm: Remove _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 12:54:43 -0500
From:	Felipe Balbi <balbi@...com>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	<balbi@...com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver
 probe method

On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote:
> On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote:
> > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote:
> > > Hello.
> > > 
> > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote:
> > > 
> > > >From: "Ivan T. Ivanov" <iivanov@...sol.com>
> > > 
> > > >This fixes following:
> > > 
> > > >WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe()
> > > >The variable msm_otg_driver references
> > > >the function __init msm_otg_probe()
> > > 
> > >    Hm, this warning shouldn't occur before patch #4, no?
> > 
> > good catch, this could probably be merged there.
> 
> True. Should I resend it?

hold on, that's simple enough to sort out while applying. Unless there
are any other big comments with your series, no need to resend.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)