linux-kernel - RE: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <001301cf636e$f6032f70$e2098e50$@samsung.com>
Date:	Tue, 29 Apr 2014 14:50:44 +0900
From:	Jonghwan Choi <jhbird.choi@...sung.com>
To:	'Viresh Kumar' <viresh.kumar@...aro.org>
Cc:	'open list' <linux-kernel@...r.kernel.org>,
	"'Rafael J. Wysocki'" <rjw@...ysocki.net>,
	'Len Brown' <len.brown@...el.com>
Subject: RE: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of
 list_for_each_entry

Hi~

> > Most of the cpufreq table is sorted in descending order.
> 
> Which part of kernel says that?
> 
-> I couldn't check all. Sorry.

> > But when cpufreq table is made from dev_pm_opp_init_cpufreq_table, it
> > is sorted in ascending order. So in some case to make cpufreq table
> > with descending order it needs an extra work.
> 
> Order of this table shouldn't matter at all in cpufreq layer..
-> You are right. But 5440 cpufreq driver write an index number instead of
clk divider value
for change DVFS. And our another(will submit) also write an index number for
changing DVFS.
As you said, order of table shouldn't matter at all in cpufreq layer. Then,
could this can be applied?
In our case, We want to use index 0 for P0 and index 1 for P1.....

Thanks

Best Ragrds.   



> -----Original Message-----
> From: viresh.linux@...il.com [mailto:viresh.linux@...il.com] On Behalf Of
> Viresh Kumar
> Sent: Tuesday, April 29, 2014 2:33 PM
> To: Jonghwan Choi
> Cc: open list; Rafael J. Wysocki; Len Brown
> Subject: Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead
> of list_for_each_entry
> 
> On Tue, Apr 29, 2014 at 10:54 AM, Jonghwan Choi <jhbird.choi@...sung.com>
> wrote:
> > Most of the cpufreq table is sorted in descending order.
> 
> Which part of kernel says that?
> 
> > But when cpufreq table is made from dev_pm_opp_init_cpufreq_table, it
> > is sorted in ascending order. So in some case to make cpufreq table
> > with descending order it needs an extra work.
> 
> Order of this table shouldn't matter at all in cpufreq layer..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/