linux-kernel - Re: [PATCH] SCHED: remove proliferation of wait_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140501093140.GN11096@twins.programming.kicks-ass.net>
Date:	Thu, 1 May 2014 11:31:40 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	David Howells <dhowells@...hat.com>,
	Steven Whitehouse <swhiteho@...hat.com>, dm-devel@...hat.com,
	Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
	Steve French <sfrench@...ba.org>,
	Theodore Ts'o <tytso@....edu>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Ingo Molnar <mingo@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action
 functions.

On Thu, May 01, 2014 at 07:26:05PM +1000, NeilBrown wrote:
> On Thu, 1 May 2014 09:42:57 +0200 Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Thu, May 01, 2014 at 12:37:38PM +1000, NeilBrown wrote:
> > > +static inline int
> > > +wait_on_bit(void *word, int bit, unsigned mode)
> > > +{
> > > +	if (!test_bit(bit, word))
> > > +		return 0;
> > > +	return out_of_line_wait_on_bit(word, bit,
> > > +				       bit_wait,
> > > +				       mode & 65535);
> > > +}
> > 
> > Still puzzled by the 16 bit mask there ;-)
> 
> I clearly remember removing that!
> And I've just done it again.
> I hope it doesn't re-reappear!
> :-)
> NeilBrown

Seems dead now, I'll hold out for a little while so that dhowells can
explain this fscache thing.

Then I'll queue it. Ingo is currently enjoying a long weekend and is
fighting (well I am now) a stability issue in -tip kernels, so it might
be a little while before it actually shows up in the git tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/