linux-kernel - Re: [PATCH] SCHED: remove proliferation of wait_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30769.1399997170@warthog.procyon.org.uk>
Date:	Tue, 13 May 2014 17:06:10 +0100
From:	David Howells <dhowells@...hat.com>
To:	NeilBrown <neilb@...e.de>
Cc:	dhowells@...hat.com, Peter Zijlstra <peterz@...radead.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Steven Whitehouse <swhiteho@...hat.com>, dm-devel@...hat.com,
	Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
	Steve French <sfrench@...ba.org>,
	"Theodore Ts'o" <tytso@....edu>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Ingo Molnar <mingo@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions.

NeilBrown <neilb@...e.de> wrote:

> The wait_on_bit() call in __fscache_wait_on_invalidate() was ambiguous
> as it specified TASK_UNINTERRUPTIBLE but used
> fscache_wait_bit_interruptible as an action function.
> As any error return is never checked I assumed that 'uninterruptible'
> was correct.

Bug.  It should be uninterruptible in both places.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/