linux-kernel - Re: [RFC PATCH RT] netconsole: enable netconsole on PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <536256EC.1060909@windriver.com>
Date:	Thu, 1 May 2014 10:15:08 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Daniel Bristot de Oliveira <bristot@...hat.com>,
	<linux-rt-users@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH RT] netconsole: enable netconsole on PREEMPT_RT

On 14-04-29 01:55 PM, Daniel Bristot de Oliveira wrote:
> Dear RT Folks,
> 
> This patch enables the netconsole on PREEMPT_RT_FULL, netconsole
> was disabled on commit:
> cb7cb77 kconfig-disable-a-few-options-rt.patch
> 
> I tested the netconsole on three machines:
> 
> - Intel Core i5 (4 cpus) - Local network
> - Intel Xeon (32 cpus)   - Remote network
> - KVM VM (on a Core i7)  - Virtual network

Chances are the two real targets above were using the
same igb network driver.  I wonder if it matters what
underlying nic is used for netconsole?

It is probably worthwhile to do some data mining into why
it was disabled in the 1st place.  I can't say I recall, and
it is possible that the reason has long since become irrelevant,
even though the patch has been carried forward over time.

Or it may be that your testing simply doesn't cover the use
case where netconsole will spew sleeping while atomic...

P.
--

> 
> On these machines I build the kernel 3.10.34-rt34 + netconsole
> built as module. In order to execute some printks, I run a small
> benchmark that runs as a module. To analyse the output I captured
> the netconsole messages using Wireshark.
> 
> On all cases, the tests passed without any error:
> 
> - No error messages from the kernel
> - No missed messages
> - No out of order messages
> 
> I ran +1 hour tests on each machine. The test using the Xeon machine
> ran by around 10 hours. On this test I received 317149 netconsole's
> messages.
> 
> I also read the code and ran some traces (using the ftrace's
> function_graph). In the traces that I read, the netconsole code never
> broke the rt lock assumptions.
> 
> Signed-off-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> ---
>  drivers/net/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 096de88..3835321 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -164,7 +164,6 @@ config VXLAN
>  
>  config NETCONSOLE
>  	tristate "Network console logging support"
> -	depends on !PREEMPT_RT_FULL
>  	---help---
>  	If you want to log kernel messages over the network, enable this.
>  	See <file:Documentation/networking/netconsole.txt> for details.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/