linux-kernel - Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140501141510.GW3245@sirena.org.uk>
Date:	Thu, 1 May 2014 07:15:10 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	alsa-devel@...a-project.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, lgirdwood@...il.com,
	robh+dt@...nel.org, sbkim73@...sung.com, rdunlap@...radead.org,
	dianders@...omium.org
Subject: Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

On Thu, May 01, 2014 at 04:59:08PM +0530, Tushar Behera wrote:

> Okay, I will extend the existing clock driver to support XCLKOUT.

It may make more sense to add another clock driver for this clock
depending on how things are done, I don't know.

> Of the many parents of XCLKOUT, we need to set XXTI clock as the parent.
> Is it okay if we pass two clocks "mclk" (XCLKOUT) and "mclk_parent"
> (XXTI) to sound-card driver via DT and do the necessary reparenting
> during the sound-card driver probe call?

No, that's not OK at all, it won't allow for configuration of the
system.  This is what I was talking about when I was talking the clock
framework extensions to allow the clock tree to be configured using DT,
that would allow the settings to be put in DT.

> Else, we can push that change to bootloader (to set the XCLKOUT mux
> register) and only enable/disable the clock in sound-card driver.

That's not going to work given that the existing bootloaders don't do
this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)