lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 May 2014 08:27:10 +0200 From: Ingo Molnar <mingo@...nel.org> To: "Luck, Tony" <tony.luck@...el.com> Cc: Mathieu Souchaud <mattieu.souchaud@...e.fr>, "bp@...en8.de" <bp@...en8.de>, "tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>, "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling * Luck, Tony <tony.luck@...el.com> wrote: > +err_device_create: > + /* > + * mce_device_remove behave properly if mce_device_create was not > + * called on that device. > + */ > + for_each_possible_cpu(i) > + mce_device_remove(i); > > grammar comment "s/behave/behaves/" > > Though perhaps this is better: > > /* > * We didn't keep track of which devices were created above, but > * even if we had, the set of online cpus might have changed. > * Play safe and remove for every possible cpu since mce_device_remove() > * will do the right thing. > */ and I guess: s/cpu since/cpu, since/ ? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists