linux-kernel - Re: [PATCH 23/24] net, diet: Add coccinelle script to convert drivers to ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140506.110504.2135392385828482331.davem@davemloft.net>
Date:	Tue, 06 May 2014 11:05:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.palix@...g.fr
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	tom.zanussi@...ux.intel.com, ak@...ux.intel.com,
	Julia.Lawall@...6.fr, Gilles.Muller@...6.fr
Subject: Re: [PATCH 23/24] net, diet: Add coccinelle script to convert
 drivers to ETHTOOL_OPS

From: Nicolas Palix <nicolas.palix@...g.fr>
Date: Tue, 6 May 2014 11:27:27 +0200

> I saw you rejected almost the entire patch series.
> 
> However, is there any interest to enforce the use of SET_ETHTOOL_OPS ?
> Are you likely to merge the patch 24/24 [1] ?

SET_ETHTOOL_OPS only exists so that drivers could be compiled
on "older" kernels.

But the usefulness of that is long gone, we've had netdev->ethtool_ops
since way before we started using GIT.

I'd rather see a patch which removes it, to be honest.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/