[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6609032.iqZgu2KXQo@wuerfel>
Date: Wed, 07 May 2014 09:38 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: linux-doc@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Joerg Roedel <joro@...tes.org>,
Randy Dunlap <rdunlap@...radead.org>,
Liviu Dudau <Liviu.Dudau@....com>,
linux-kernel@...r.kernel.org,
James Bottomley <jbottomley@...allels.com>,
linux-pci@...r.kernel.org, David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v2 2/5] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t
On Tuesday 06 May 2014 16:48:26 Bjorn Helgaas wrote:
> dma_declare_coherent_memory() takes two addresses for a region of memory: a
> "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is
> the physical address a *CPU* would use to access the region, and
> "device_addr" is the bus address the *device* would use to address the
> region.
>
> Rename "bus_addr" to "phys_addr" and change its type to phys_addr_t.
> Most callers already supply a phys_addr_t for this argument. The others
> supply a 32-bit integer (a constant, unsigned int, or __u32) and need no
> change.
>
> Use "unsigned long", not phys_addr_t, to hold PFNs.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
>
Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists