linux-kernel - Re: [PATCH] [linux-next] pwm: lpss: fix const qualifier discard warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140507084137.GD6362@ulmo>
Date:	Wed, 7 May 2014 10:41:38 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Jan Moskyto Matejka <mq@...e.cz>
Cc:	Alan Cox <alan@...ux.intel.com>, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [linux-next] pwm: lpss: fix const qualifier discard
 warning

On Fri, May 02, 2014 at 05:22:59PM +0200, Jan Moskyto Matejka wrote:
> Fixing this warning:
> drivers/pwm/pwm-lpss.c: In function ‘pwm_lpss_probe_pci’:
> drivers/pwm/pwm-lpss.c:192:2: warning: passing argument 3 of ‘pwm_lpss_probe’ discards ‘const’ qualifier from pointer target type [enabled by default]
>   lpwm = pwm_lpss_probe(&pdev->dev, &pdev->resource[0], info);
>   ^
> drivers/pwm/pwm-lpss.c:130:30: note: expected ‘struct pwm_lpss_boardinfo *’ but argument is of type ‘const struct pwm_lpss_boardinfo *’
>  static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev,
> 
> That warning was introduced in commit 093e00bb3f82f3c67e2d1682e316fc012bcd0d92
> ("pwm: lpss: Add support for PCI devices").
> 
> Signed-off-by: Jan Moskyto Matejka <mq@...e.cz>
> ---
>  drivers/pwm/pwm-lpss.c | 1 +
>  1 file changed, 1 insertion(+)

This was reported over a week ago by the kbuild test robot and I've had
fixes for this (and an additional sparse warning) in my tree for a while
now. Interestingly everybody at Intel seems to have forgotten about this
driver after their patches got merged since nobody cared to respond.

I've now pushed out the patch that I had locally.

Thanks,
Thierry

Content of type "application/pgp-signature" skipped