linux-kernel - Re: [PATCH] [linux-next] pwm: lpss: fix const qualifier discard warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399456133.2458.52.camel@acox1-desk.ger.corp.intel.com>
Date:	Wed, 07 May 2014 10:48:53 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Jan Moskyto Matejka <mq@...e.cz>, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [linux-next] pwm: lpss: fix const qualifier discard
 warning

On Wed, 2014-05-07 at 10:41 +0200, Thierry Reding wrote:
> On Fri, May 02, 2014 at 05:22:59PM +0200, Jan Moskyto Matejka wrote:
> > Fixing this warning:
> > drivers/pwm/pwm-lpss.c: In function ‘pwm_lpss_probe_pci’:
> > drivers/pwm/pwm-lpss.c:192:2: warning: passing argument 3 of ‘pwm_lpss_probe’ discards ‘const’ qualifier from pointer target type [enabled by default]
> >   lpwm = pwm_lpss_probe(&pdev->dev, &pdev->resource[0], info);
> >   ^
> > drivers/pwm/pwm-lpss.c:130:30: note: expected ‘struct pwm_lpss_boardinfo *’ but argument is of type ‘const struct pwm_lpss_boardinfo *’
> >  static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev,
> > 
> > That warning was introduced in commit 093e00bb3f82f3c67e2d1682e316fc012bcd0d92
> > ("pwm: lpss: Add support for PCI devices").
> > 
> > Signed-off-by: Jan Moskyto Matejka <mq@...e.cz>
> > ---
> >  drivers/pwm/pwm-lpss.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> This was reported over a week ago by the kbuild test robot and I've had
> fixes for this (and an additional sparse warning) in my tree for a while
> now. Interestingly everybody at Intel seems to have forgotten about this
> driver after their patches got merged since nobody cared to respond.

No - like everyone else we're all juggling multiple things. Also
remember there have just been a bunch of public holidays on large parts
of the planet.

I did see Jan's email but I didn't realise it needed a response, it was
clearly and obviously correct.

Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/