linux-kernel - Re: [PATCH v1 03/11] perf: Allow for multiple ring buffers per event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140508141611.GB30445@twins.programming.kicks-ass.net>
Date:	Thu, 8 May 2014 16:16:11 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH v1 03/11] perf: Allow for multiple ring buffers per event

On Thu, May 08, 2014 at 03:46:36PM +0300, Alexander Shishkin wrote:
> Peter Zijlstra <peterz@...radead.org> writes:
> 
> > On Thu, May 08, 2014 at 03:34:17PM +0300, Alexander Shishkin wrote:
> >> Peter Zijlstra <peterz@...radead.org> writes:
> >> 
> >> > So the aux_head/tail values should also be in the file space and not
> >> > start at 0 again, similar for the offsets in the AUX record.
> >> 
> >> Thinking some more about it: if we keep aux_{offset,size} in userpg,
> >> then it would make sense to have aux_{head,tail} run from 0 to infinity
> >> similar to data_{head,tail}, especially considering that neither data_*
> >> nor aux_* pointers are file offsets anyway.
> >
> > Yeah, this might make it easier. So then the rule is *_offset +
> > *_{head,tail} is the actual file offset into the buffer.
> 
> You mean *_offset + (*_{head,tail} % *_size) ?

Indeed I did.. 

Content of type "application/pgp-signature" skipped