linux-kernel - Re: [PATCH 07/20] arch,cris: Fold atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140508160606.GD30445@twins.programming.kicks-ass.net>
Date:	Thu, 8 May 2014 18:06:06 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Will Deacon <will.deacon@....com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Mikael Starvik <starvik@...s.com>
Subject: Re: [PATCH 07/20] arch,cris: Fold atomic_ops

On Thu, May 08, 2014 at 05:12:31PM +0200, Geert Uytterhoeven wrote:
> Hi Peter,
> 
> On Thu, May 8, 2014 at 3:58 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> > Many of the atomic op implementations are the same except for one
> > instruction; fold the lot into a few CPP macros and reduce LoC.
> >
> > This also prepares for easy addition of new ops.
> >
> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Cc: Jesper Nilsson <jesper.nilsson@...s.com>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: Mikael Starvik <starvik@...s.com>
> > Signed-off-by: Peter Zijlstra <peterz@...radead.org>
> > ---
> >  arch/cris/include/arch-v10/arch/system.h |    2 -
> >  arch/cris/include/asm/atomic.h           |   57 +++++++++++++------------------
> >  2 files changed, 25 insertions(+), 34 deletions(-)
> >
> > Index: linux-2.6/arch/cris/include/arch-v10/arch/system.h
> > ===================================================================
> > --- linux-2.6.orig/arch/cris/include/arch-v10/arch/system.h
> > +++ linux-2.6/arch/cris/include/arch-v10/arch/system.h
> > @@ -36,8 +36,6 @@ static inline unsigned long _get_base(ch
> >    return 0;
> >  }
> >
> > -#define nop() __asm__ __volatile__ ("nop");
> > -
> 
> Is this change supposed to be part of this series?

Uhm, lemme double check that. Good spotting.

Nope, it builds just fine without that hunk, *poof* gone.

Thanks!


Content of type "application/pgp-signature" skipped