linux-kernel - Re: [PATCH 07/20] arch,cris: Fold atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140508.133451.1383193780216133211.davem@davemloft.net>
Date:	Thu, 08 May 2014 13:34:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peterz@...radead.org
Cc:	geert@...ux-m68k.org, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, mingo@...nel.org, will.deacon@....com,
	paulmck@...ux.vnet.ibm.com, jesper.nilsson@...s.com,
	starvik@...s.com
Subject: Re: [PATCH 07/20] arch,cris: Fold atomic_ops

From: Peter Zijlstra <peterz@...radead.org>
Date: Thu, 8 May 2014 18:06:06 +0200

> On Thu, May 08, 2014 at 05:12:31PM +0200, Geert Uytterhoeven wrote:
>> Hi Peter,
>> 
>> On Thu, May 8, 2014 at 3:58 PM, Peter Zijlstra <peterz@...radead.org> wrote:
>> > Many of the atomic op implementations are the same except for one
>> > instruction; fold the lot into a few CPP macros and reduce LoC.
>> >
>> > This also prepares for easy addition of new ops.
>> >
>> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> > Cc: Jesper Nilsson <jesper.nilsson@...s.com>
>> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>> > Cc: Mikael Starvik <starvik@...s.com>
>> > Signed-off-by: Peter Zijlstra <peterz@...radead.org>
>> > ---
>> >  arch/cris/include/arch-v10/arch/system.h |    2 -
>> >  arch/cris/include/asm/atomic.h           |   57 +++++++++++++------------------
>> >  2 files changed, 25 insertions(+), 34 deletions(-)
>> >
>> > Index: linux-2.6/arch/cris/include/arch-v10/arch/system.h
>> > ===================================================================
>> > --- linux-2.6.orig/arch/cris/include/arch-v10/arch/system.h
>> > +++ linux-2.6/arch/cris/include/arch-v10/arch/system.h
>> > @@ -36,8 +36,6 @@ static inline unsigned long _get_base(ch
>> >    return 0;
>> >  }
>> >
>> > -#define nop() __asm__ __volatile__ ("nop");
>> > -
>> 
>> Is this change supposed to be part of this series?
> 
> Uhm, lemme double check that. Good spotting.
> 
> Nope, it builds just fine without that hunk, *poof* gone.

You did this for sparc too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/