[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140509104202.GG4963@mwanda>
Date: Fri, 9 May 2014 13:42:02 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Daeseok Youn <daeseok.youn@...il.com>
Cc: gregkh@...uxfoundation.org, himangi774@...il.com,
sachin.kamat@...aro.org, fempsci@...il.com, nandu.hgowda@...il.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: cxt1e1: Fix no spaces at the start of a
line in musycc.c
On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
> clean up checkpatch.pl warning:
> WARNING: please no spaces at the start of a line in
>
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
> -#ifdef RLD_TRANS_DEBUGx
> - if (1 || cxt1e1_log_level >= LOG_MONITOR2)
> +#ifdef RLD_TRANS_DEBUG
> + if (1 || cxt1e1_log_level >= LOG_MONITOR2)
> #else
You fixed a typo here. I don't care about it, because we are going to
delete this code anyway. But normally I would ask you to redo the patch
because it should be done separately, and it should be described in the
changelog instead of slipped in secretly.
But in this case, I don't care so you got lucky.
Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists