linux-kernel - Re: [PATCH 1/5] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 May 2014 22:56:59 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, himangi774@...il.com,
	sachin.kamat@...aro.org, fempsci@...il.com, nandu.hgowda@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: cxt1e1: Fix no spaces at the start of a line
 in musycc.c

2014-05-09 19:42 GMT+09:00, Dan Carpenter <dan.carpenter@...cle.com>:
> On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warning:
>>  WARNING: please no spaces at the start of a line in
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> ---
>
>> -#ifdef RLD_TRANS_DEBUGx
>> -    if (1 || cxt1e1_log_level >= LOG_MONITOR2)
>> +#ifdef RLD_TRANS_DEBUG
>> +	if (1 || cxt1e1_log_level >= LOG_MONITOR2)
>>  #else
>
> You fixed a typo here.  I don't care about it, because we are going to
> delete this code anyway.  But normally I would ask you to redo the patch
> because it should be done separately, and it should be described in the
> changelog instead of slipped in secretly.
Oh.. I didn't know that fixed typo is in this patch. :-)
>
> But in this case, I don't care so you got lucky.
Thanks.

Regards,
Daeseok Youn
>
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/