linux-kernel - Re: [RFC PATCH] ima: audit log files opened with O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1399979458.2925.18.camel@dhcp-9-2-203-236.watson.ibm.com>
Date:	Tue, 13 May 2014 07:10:58 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	"J. R. Okajima" <hooanon05g@...il.com>
Cc:	linux-security-module <linux-security-module@...r.kernel.org>,
	Dmitry Kasatkin <d.kasatkin@...sung.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ima: audit log files opened with O_DIRECT flag

On Tue, 2014-05-13 at 16:19 +0900, J. R. Okajima wrote: 
> Mimi Zohar:
> > As a temporary fix, do not measure, appraise, or audit files
> > opened with the O_DIRECT flag set.  Just audit log it.
> 
> I have no objection about the patch, but have a question.
> Are you intending to put it into mainline now (and stable too)? Or is
> this a local bandage for whoever have met the problem (like me)?

Yes, for the time being.

> In other words, should I wait for another lock free solution from Dmitry
> Kasatkin?

In addition to the lockdep issue, there is a separate problem of reading
the file opened w/O_DIRECT flag.  Dmitry is about to post two patches,
with a detailed explanation.  The first patch re-introduces the
iint->mutex.  The other patch reads the file opened w/O_DIRECT flag.
Neither patch is trivial.

> By the way, the mail is not delivered to stable-ML while there is
> "Cc: stable..." line in the commit log.

The CC shouldn't have been included in an RFC.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/