linux-kernel - Re: [PATCH] vfs: add noreplace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140513140557.GA30660@infradead.org>
Date:	Tue, 13 May 2014 07:05:57 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Al Viro <viro@...IV.linux.org.uk>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, Chris Mason <clm@...com>,
	Jan Kara <jack@...e.cz>, Theodore Ts'o <tytso@....edu>,
	Jaegeuk Kim <jaegeuk.kim@...sung.com>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Mikulas Patocka <mpatocka@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Kleikamp <dave.kleikamp@...cle.com>,
	Joern Engel <joern@...fs.org>,
	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>,
	Bob Copeland <me@...copeland.com>,
	Christoph Hellwig <hch@...radead.org>,
	Artem Bityutskiy <dedekind1@...il.com>,
	Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH] vfs: add noreplace_rename2()

On Tue, May 13, 2014 at 03:56:22PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> RENAME_NOREPLACE is trivial to implement for most filesystems.  This adds a
> helper that can be assigned to ->rename2() and calls ->rename().
> 
> Only suitable for local filesystems, i.e. those that cannot have files
> "spontaneously" appear (like NFS and friends).

I don't like this approach at all.  Please bite the bullet and rename
->rename2 to ->rename and all the proper rejecting of non-supported
flags intstead of further locking down the duplication.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/