| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 May 2014 16:43:54 +0200 From: Miklos Szeredi <miklos@...redi.hu> To: Christoph Hellwig <hch@...radead.org> Cc: Al Viro <viro@...IV.linux.org.uk>, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, Stephen Rothwell <sfr@....ibm.com> Subject: Re: [PATCH] vfs: add noreplace_rename2() On Tue, May 13, 2014 at 07:05:57AM -0700, Christoph Hellwig wrote: > On Tue, May 13, 2014 at 03:56:22PM +0200, Miklos Szeredi wrote: > > From: Miklos Szeredi <mszeredi@...e.cz> > > > > RENAME_NOREPLACE is trivial to implement for most filesystems. This adds a > > helper that can be assigned to ->rename2() and calls ->rename(). > > > > Only suitable for local filesystems, i.e. those that cannot have files > > "spontaneously" appear (like NFS and friends). > > I don't like this approach at all. Please bite the bullet and rename > ->rename2 to ->rename and all the proper rejecting of non-supported > flags intstead of further locking down the duplication. There was pushback from Stephen Rothwell as well as Al, which is why it ended up being a separate op. I was always hoping to merge the two, but until there's clear indication that it's going to get accepted, there's no point in me preparing and maintaining such a patch. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists