linux-kernel - Re: [PATCH 1/1] fs/cifs/netmisc.c: convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 May 2014 09:30:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Steve French <sfrench@...ba.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fs/cifs/netmisc.c: convert printk to pr_foo()

On Tue, 2014-05-13 at 18:10 +0200, Fabian Frederick wrote:
> Also fixes array checkpatch warning.
[]
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
[]
> @@ -941,8 +941,8 @@ cifs_UnixTimeToNT(struct timespec t)
>  	return (u64) t.tv_sec * 10000000 + t.tv_nsec/100 + NTFS_TIME_OFFSET;
>  }
>  
> -static int total_days_of_prev_months[] =
> -{0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};
> +static int total_days_of_prev_months[] = {
> +	0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};

Hi Fabian.

A preferred form for initialized array declarations is

type array[] = {
	val1, val2, ..., valn
};

Also this instance should probably be static const.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/