linux-kernel - Re: [PATCH 1/1] fs/devpts/inode.c: convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399998910.24350.8.camel@joe-AO725>
Date:	Tue, 13 May 2014 09:35:10 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, tytso <tytso@....edu>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fs/devpts/inode.c: convert printk to pr_foo()

On Tue, 2014-05-13 at 18:13 +0200, Fabian Frederick wrote:
> Also convert spaces to tabs (checkpatch warnings)
[]
> diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
[]

It may be better to add a #define pr_fmt

> @@ -225,7 +225,7 @@ static int parse_mount_options(char *data, int op, struct pts_mount_opts *opts)
>  			break;
>  #endif
>  		default:
> -			printk(KERN_ERR "devpts: called with bogus options\n");
> +			pr_err("devpts: called with bogus options\n");

and remove all the embedded "devpts: "

> @@ -261,7 +261,7 @@ static int mknod_ptmx(struct super_block *sb)
>  
>  	dentry = d_alloc_name(root, "ptmx");
>  	if (!dentry) {
> -		printk(KERN_NOTICE "Unable to alloc dentry for ptmx node\n");
> +		pr_notice("Unable to alloc dentry for ptmx node\n");
>  		goto out;
>  	}
>  
> @@ -270,7 +270,7 @@ static int mknod_ptmx(struct super_block *sb)
>  	 */
>  	inode = new_inode(sb);
>  	if (!inode) {
> -		printk(KERN_ERR "Unable to alloc inode for ptmx node\n");
> +		pr_err("Unable to alloc inode for ptmx node\n");
>  		dput(dentry);
>  		goto out;
>  	}

Adding pr_fmt would prefix these.

It seems odd that one of these is an err and the other a notice.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/