linux-kernel - Re: [PATCH 09/10] ARM: dts: OMAP4: clk: Add clk node for DES IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 May 2014 12:04:06 +0300
From:	Tero Kristo <t-kristo@...com>
To:	Joel Fernandes <joelf@...com>, Tony Lindgren <tony@...mide.com>,
	Benoit Cousson <bcousson@...libre.com>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
CC:	Lokesh Vutla <lokeshvutla@...com>
Subject: Re: [PATCH 09/10] ARM: dts: OMAP4: clk: Add clk node for DES IP

On 04/26/2014 02:02 AM, Joel Fernandes wrote:
> From: Lokesh Vutla <lokeshvutla@...com>
>
> DES IP already has main and interface clk as des_fck.
> Node for des_fck is missing in clk tree. Adding the same.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@...com>
> Signed-off-by: Joel Fernandes <joelf@...com>
> ---
>   arch/arm/boot/dts/omap44xx-clocks.dtsi |    8 ++++++++
>   drivers/clk/ti/clk-44xx.c              |    1 +
>   2 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> index c821ff5..83cf189 100644
> --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> @@ -985,6 +985,14 @@
>   		reg = <0x15a8>;
>   	};
>
> +	des_fck: des_fck@...095b0 {
> +	       #clock-cells = <0>;
> +	       compatible = "gate-clock";
> +	       clocks = <&l3_div_ck>;
> +	       bit-shift = <1>;
> +	       reg = <0x4a0095b0 0x4>;

NAK.

Obsolete compatible type used, also obsolete register format used.

-Tero

> +	};
> +
>   	dss_sys_clk: dss_sys_clk {
>   		#clock-cells = <0>;
>   		compatible = "ti,gate-clock";
> diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
> index 02517a8..85d97c3 100644
> --- a/drivers/clk/ti/clk-44xx.c
> +++ b/drivers/clk/ti/clk-44xx.c
> @@ -120,6 +120,7 @@ static struct ti_dt_clk omap44xx_clks[] = {
>   	DT_CLK(NULL, "syc_clk_div_ck", "syc_clk_div_ck"),
>   	DT_CLK(NULL, "aes1_fck", "aes1_fck"),
>   	DT_CLK(NULL, "aes2_fck", "aes2_fck"),
> +	DT_CLK(NULL, "des_fck", "des_fck"),
>   	DT_CLK(NULL, "dmic_sync_mux_ck", "dmic_sync_mux_ck"),
>   	DT_CLK(NULL, "func_dmic_abe_gfclk", "func_dmic_abe_gfclk"),
>   	DT_CLK(NULL, "dss_sys_clk", "dss_sys_clk"),
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/