linux-kernel - Re: [PATCH 07/10] ARM: dts: DRA7: Add DT node for DES IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 11:38:33 -0500
From:	Joel Fernandes <joelf@...com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Tony Lindgren <tony@...mide.com>,
	Benoit Cousson <bcousson@...libre.com>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/10] ARM: dts: DRA7: Add DT node for DES IP

On 04/26/2014 11:36 AM, Sergei Shtylyov wrote:
> Hello.
> 
> On 26-04-2014 3:02, Joel Fernandes wrote:
> 
>> DRA7xx SoCs have a DES3DES IP. Add DT data for the same.
> 
>> Signed-off-by: Joel Fernandes <joelf@...com>
>> ---
>>   arch/arm/boot/dts/dra7.dtsi |   11 +++++++++++
>>   1 file changed, 11 insertions(+)
> 
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 1c0f8e1..0533b89 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -789,6 +789,17 @@
>>               dma-names = "tx0", "rx0";
>>               status = "disabled";
>>           };
>> +
>> +        des: des@...a5000 {
> 
>    Shouldn't the node name be "crypto@...a5000", according to the ePAPR
> standard?
> 
Actually I'm not a big fan of the standard here in this regard.
"crypto@...a5000" doesn't mean anything and serves no purpose for
anyone. There are quite a few crypto modules and such a name doesn't
help and is confusing at best.

There's no property either in the device tree node itself to describe it
as des, except for the phandle label which is used only at dt
compile-time if I'm right. So makes sense to have the name be more specific.

This is how we have added dts nodes for other crypto modules in the past...

thanks,
 -Joel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/