linux-kernel - Re: [PATCH 0/6] sched: expel confusing usage of the term "power"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 09:41:11 +0200
From:	Vincent Guittot <vincent.guittot@...aro.org>
To:	Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Morten Rasmussen <morten.rasmussen@....com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>
Subject: Re: [PATCH 0/6] sched: expel confusing usage of the term "power"

Hi Nico,

Thanks for doing this renaming.
I remember that you asked me to do this while working on cpu_power but
my work has not evolved as fast as expected and as it already implies
some renaming other than s/power/capacity/ i have postponed it to not
make review to complex.

Nevertheless, i can manage the conflicts afterward and rebase my
patches, depending of the review status

Vincent

On 14 May 2014 22:57, Nicolas Pitre <nicolas.pitre@...aro.org> wrote:
> "Power" is a very bad term in the scheduler context.  There are so many
> meanings that can be attached to it.  And with the upcoming "power
> aware" scheduler work confusion is sure to happen.
>
> The definition of "power" is typically the rate at which work is performed,
> energy is converted or electric energy is transferred.  The notion of
> "compute capacity" is rather at odds with "power" to the point many
> comments in the code have to make it explicit that "capacity" is the
> actual intended meaning.
>
> So let's make it clear what we man by using "capacity" in place of "power"
> directly in the code.  That will make the introduction of actual "power
> consumption" concepts much clearer later on.
>
> This is based on the latest tip tree where scheduler changes are already
> queued.
>
> Note: The diffstat is not completely symetric wrt added/removed lines as
> some comments were reflowed.
>
>
>  arch/arm/kernel/topology.c |  54 +++----
>  include/linux/sched.h      |   8 +-
>  kernel/sched/core.c        |  89 ++++++-----
>  kernel/sched/fair.c        | 322 ++++++++++++++++++++-------------------
>  kernel/sched/sched.h       |  18 +--
>  5 files changed, 246 insertions(+), 245 deletions(-)
>
>
> Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/