linux-kernel - Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 18:34:41 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	balbi@...com
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>,
	Amit Uttamchandani <auttamchandani@...icube.com>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

On 15 May 2014 18:07, "Felipe Balbi" <balbi@...com> wrote:
>
> On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote:
> > This patch adds support for the PLX USB3380 and USB3382.
> >
> > This driver is based on the driver from the manufacturer.
> >
> > Since USB338X is register compatible with NET2280, I thought that it
> > would be better to include this hardware into net2280 driver.
> >
> > Manufacturer's driver only supported the USB33X, did not follow the
> > Kernel Style and contain some trivial errors. This patch has tried to
> > address this issues.
> >
> > This patch has only been tested on USB338x hardware, but the merge has
> > been done trying to not affect the behaviour of NET2280.
> >
> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>
> anybody with net2280, please give me a Tested-by so I'm sure there are
> no regressions caused by this patch. One question though, is it worth to
> use the legacy mode just to get register compatibility ? What are the
> drawbacks of using legacy mode ? Is any feature missing when we use
> legacy mode ?
>
> cheers

This patch is a merge of the full driver from plx with the net2280
driver. It should support enhanced and legacy mode. The mode is
selected with a pull up/down on a pin.

I have tested it with a usb3880 EV board in USB 3.0 and 2.0

According to the doc. The chip in legacy mode should be a almost 100%
compatible with the old driver. But of course no superspeed is
available with the unmodified net2280 driver. Also there are some
erratas that needs to be addressed.

"
As the successor of the gold standard NET 2280, PCI to USB 2.0
Peripheral Controller, the USB 3380 can be used with existing NET 2280
software with no or minimal change."

On enhanced mode there are more endpoints and some other improvements.

Regards

PS sorry for the double post. The first one was in HTML thanks to gmail app :P

>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/