linux-kernel - Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140515160735.GF7360@saruman.home>
Date:	Thu, 15 May 2014 11:07:35 -0500
From:	Felipe Balbi <balbi@...com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<joe@...ches.com>, <auttamchandani@...icube.com>
Subject: Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote:
> This patch adds support for the PLX USB3380 and USB3382.
> 
> This driver is based on the driver from the manufacturer.
> 
> Since USB338X is register compatible with NET2280, I thought that it
> would be better to include this hardware into net2280 driver.
> 
> Manufacturer's driver only supported the USB33X, did not follow the
> Kernel Style and contain some trivial errors. This patch has tried to
> address this issues.
> 
> This patch has only been tested on USB338x hardware, but the merge has
> been done trying to not affect the behaviour of NET2280.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>

anybody with net2280, please give me a Tested-by so I'm sure there are
no regressions caused by this patch. One question though, is it worth to
use the legacy mode just to get register compatibility ? What are the
drawbacks of using legacy mode ? Is any feature missing when we use
legacy mode ?

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)