linux-kernel - query regarding not returning error if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5374EF1A.2000609@gmail.com>
Date:	Thu, 15 May 2014 22:15:14 +0530
From:	RAGHAVENDRA GANIGA <ravi23ganiga@...il.com>
To:	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	a.zummo@...ertech.it
Subject: query regarding not returning error if request_irq fails after rtc
 registration

in ds1343 driver after the rtc is registered using devm_rtc_device_register
i am requesting irq using devm_request_threaded_irq, in case this request
fails instead of the driver bailing out it just uses dev_err to show the
error and the driver probe returns zero

my question is that the set_alarm and alarm_irq_enable is still active,
so should i use some flag in the global private variable of the driver
so that if the request irq fails, then using this flag the set_alarm
and alarm_irq_enable can return error since there is no irq handler
for the rtc interrupt 
or is there any other solution 
or let the set_alarm and alarm_irq_enable routine be as it is and will
not harm 

Thanks and Regards
Raghavendra Chandra Ganiga
Contact: +919594554858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/