linux-kernel - Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1405151511270.887-100000@iolanthe.rowland.org>
Date:	Thu, 15 May 2014 15:12:18 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Felipe Balbi <balbi@...com>
cc:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, <joe@...ches.com>,
	<auttamchandani@...icube.com>
Subject: Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

On Thu, 15 May 2014, Felipe Balbi wrote:

> On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote:
> > This patch adds support for the PLX USB3380 and USB3382.
> > 
> > This driver is based on the driver from the manufacturer.
> > 
> > Since USB338X is register compatible with NET2280, I thought that it
> > would be better to include this hardware into net2280 driver.
> > 
> > Manufacturer's driver only supported the USB33X, did not follow the
> > Kernel Style and contain some trivial errors. This patch has tried to
> > address this issues.
> > 
> > This patch has only been tested on USB338x hardware, but the merge has
> > been done trying to not affect the behaviour of NET2280.
> > 
> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> 
> anybody with net2280, please give me a Tested-by so I'm sure there are
> no regressions caused by this patch. One question though, is it worth to
> use the legacy mode just to get register compatibility ? What are the
> drawbacks of using legacy mode ? Is any feature missing when we use
> legacy mode ?

I tried it out with my net2280 card.  There didn't appear to be any 
problems under light testing.

Tested-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/