[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140517175829.GD1939@mguzik.redhat.com>
Date: Sat, 17 May 2014 19:58:30 +0200
From: Mateusz Guzik <mguzik@...hat.com>
To: Al Viro <viro@...IV.linux.org.uk>
Cc: Manuel Schölling <manuel.schoelling@....de>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: Cleanup string initializations (char[] instead of
char *)
On Sat, May 17, 2014 at 06:21:09PM +0100, Al Viro wrote:
> On Sat, May 17, 2014 at 05:44:28PM +0200, Mateusz Guzik wrote:
> > This particular function would be better of with removing this variable
> > and replacing all pairs like:
> > sprintf(dp, ...);
> > dp += strlen(...)
> >
> > with:
> > dp += sprintf(dp, ...);
>
> Sigh... Premature optimisation and all such... (..)
Well, I was interested in getting rid of this error-prone style, which
results in stuff like:
sprintf(dp, "\nmask ");
dp += 6;
... and cleaning up the rest for consistency, will note next time.
I'm new to linux and didn't know about seq_ thingy, will grep some more
next time.
--
Mateusz Guzik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists