linux-kernel - Re: [PATCH] Fix for possible null pointer dereference in node.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFo99gbnN8j8WgY3O1eDgkpkmJU11X8-9cCU_0_s7TRN8wNW+Q@mail.gmail.com>
Date:	Sun, 18 May 2014 17:49:52 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Masood Mehmood <ody.guru@...il.com>
Subject: Re: [PATCH] Fix for possible null pointer dereference in node.c

Hi

When I run cppcheck find the about 5,000 errors, of these, I selected
the 100 most serious and has made patches. But my ability to immerse
myself in each failure has been limited unfortunately.

Okay, I send it through the scripts instead.


Best regards
Rickard Strandqvist


2014-05-17 20:56 GMT+02:00 Dan Carpenter <dan.carpenter@...cle.com>:
> On Sat, May 17, 2014 at 03:21:56PM +0200, Rickard Strandqvist wrote:
>> Okay, everyone agrees with Dan..?
>>
>
> You can audit it yourself, there are only 4 callers.  The
> node_allocate() is total garbage so the second delete_node() is a bit
> complicated to read but it's not that hard.
>
>> I have made a new patch, which does not check if hnode is NULL.
>
> Send it inline so we can use our normal scripts.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/