linux-kernel - RE: [PATCH 3/5] usb: gadget: net2280: Use BIT() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 10:18:25 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Ricardo Ribalda Delgado' <ricardo.ribalda@...il.com>,
	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>,
	"auttamchandani@...icube.com" <auttamchandani@...icube.com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>
Subject: RE: [PATCH 3/5] usb: gadget: net2280: Use BIT() macro

From: Ricardo Ribalda Delgado
> Improves readability of the code

Personally I don't find macros like BIT() improve the readability at all.
What next? Maybe:

#define ADD(a, b) ((a) + (b))

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/