linux-kernel - Re: [PATCH 3/5] usb: gadget: net2280: Use BIT() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_2uTM6TB9756SHeWs424L6ERtgbk+Ea_U+VXCcaooS7dg@mail.gmail.com>
Date:	Mon, 19 May 2014 12:24:56 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	David Laight <David.Laight@...lab.com>
Cc:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>,
	"auttamchandani@...icube.com" <auttamchandani@...icube.com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>
Subject: Re: [PATCH 3/5] usb: gadget: net2280: Use BIT() macro

Hello David

I dont want to start a flame war here :) but  In the particular case
of hardware registers I believe it does.

This patch has been posted because on a previous patch to support the
usb3380, one of the requested changes was to use this macro. In order
to have consistent code in the file I have posted this patch.

BTW, I havent defined the bit macro, just used it :P

Cheers!


On Mon, May 19, 2014 at 12:18 PM, David Laight <David.Laight@...lab.com> wrote:
> From: Ricardo Ribalda Delgado
>> Improves readability of the code
>
> Personally I don't find macros like BIT() improve the readability at all.
> What next? Maybe:
>
> #define ADD(a, b) ((a) + (b))
>
>         David
>
>
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/