linux-kernel - Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wrfjtx8mrrp2.fsf@ultrasam.lan.trained-monkey.org>
Date:	Mon, 19 May 2014 12:25:13 +0200
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Karim Raslan <karim.allah.ahmed@...il.com>,
	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

Dan Carpenter <dan.carpenter@...cle.com> writes:
> On Sun, May 18, 2014 at 07:39:23AM +0100, Karim Raslan wrote:
>> This should fix a few sparse warnings like the following:
>> 
>>   CHECK   drivers/staging/rtl8723au/core/rtw_ap.c
>> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect
>> type in argument 3 (different base types)
>> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    expected int [signed] gfp
>> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    got restricted gfp_t
>> 
>
> Thanks, Karim, looks good.
>
> Jes's patch which added this never went to the list so I didn't review
> it.  This annoys me.
>
> I try to be fair when I review code.  I try to allow lots of patches in
> and let people send fix up patches for minor stuff.  But, obviously, you
> should be running Sparse as part of the review process so if I made you
> redo this patch it's because your process is broken.  When I review
> patches I am trying to help you.

Dan,

Calm down, I haven't been bombarding the list, due to the sheer volume
of commits.  If you want me to spam the list, tell me where and I'll add
that to the CC list next time.

This particular case isn't exactly a real problem either.

Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/