linux-kernel - Re: [PATCH 5/5] usb: gadget: net2280: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1405191543070.1538-100000@iolanthe.rowland.org>
Date:	Mon, 19 May 2014 15:44:53 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
cc:	balbi@...com, <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<joe@...ches.com>, <auttamchandani@...icube.com>
Subject: Re: [PATCH 5/5] usb: gadget: net2280: Use pr_* function

On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:

> Driver was using custom functions WARNING, ERROR, DEBUG, instead of
>  pr_err, pr_dgb...

What's wrong with that, and why bother to change it?

> diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
> index e67ae96..11800bb 100644
> --- a/drivers/usb/gadget/net2280.c
> +++ b/drivers/usb/gadget/net2280.c
> @@ -210,7 +210,7 @@ static int net2280_enable(struct usb_ep *_ep,
>  	 * use it instead of troublesome (non-bulk) multi-packet DMA.
>  	 */
>  	if (ep->dma && (max % 4) != 0 && use_dma_chaining) {
> -		DEBUG(ep->dev, "%s, no dma for maxpacket %d\n",
> +		dev_dbg(GETDEV(ep->dev), "%s, no dma for maxpacket %d\n",

Don't you think that the new code is harder to read than the original?  
Why go to a lot of trouble just to make things worse?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/