linux-kernel - Re: [PATCH 4/5] usb: gadget: net2280: Code Cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 21:44:53 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"balbi@...com" <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Joe Perches <joe@...ches.com>,
	Amit Uttamchandani <auttamchandani@...icube.com>
Subject: Re: [PATCH 4/5] usb: gadget: net2280: Code Cleanup

Hello Alan


I am trying to be consistent around the file. On a previous patch I
was asked to move the operators at the end. I did so, and now I am
modifying the file to look alike.



On Mon, May 19, 2014 at 9:43 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
>
>> Move logical continuations to end of line
>
> This is almost totally unnecessary.  Some people prefer the
> operators at the end of the first line, other people prefer them at the
> start of the next line.  It's just a matter of taste and it doesn't
> matter.
>
>> @@ -402,8 +402,8 @@ static void ep_reset_228x(struct net2280_regs __iomem *regs,
>>               BIT(DATA_PACKET_RECEIVED_INTERRUPT) |
>>               BIT(DATA_PACKET_TRANSMITTED_INTERRUPT) |
>>               BIT(DATA_OUT_PING_TOKEN_INTERRUPT) |
>> -             BIT(DATA_IN_TOKEN_INTERRUPT)
>> -             , &ep->regs->ep_stat);
>> +             BIT(DATA_IN_TOKEN_INTERRUPT),
>> +             &ep->regs->ep_stat);
>
> This is an example of the one type of change that does make sense.
> Nobody should start lines with a ','.
>
> Alan Stern
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/