linux-kernel - RE: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17249DE6@AcuExch.aculab.com>
Date:	Tue, 20 May 2014 08:52:33 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Alan Stern' <stern@...land.harvard.edu>,
	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
CC:	Felipe Balbi <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>,
	"auttamchandani@...icube.com" <auttamchandani@...icube.com>
Subject: RE: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

From: Alan Stern
...
> > -static struct usb_request *
> > -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags)
> > +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep,
> > +							gfp_t gfp_flags)
> 
> What's with the extreme indentation on the continuation line?  The
> style used here is for continuation lines to be indented by two stops
> relative to the first line.

Also why move the line break?
The Linux kernel has both styles, and the original one (with the
function name starting in column 1) makes it much easier to search
to the definition.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/