linux-kernel - Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140520100252.GA16428@pd.tnic>
Date:	Tue, 20 May 2014 12:02:52 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	Chen Yucong <slaoub@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

On Mon, May 19, 2014 at 10:06:38PM +0000, Luck, Tony wrote:
> I doubt there is any hope for recovery if not all processors show up
> ... things have to be already very broken for the machine check to be
> blocked.

Good, so this whole babble about the potential of a timeout and whatever
is all beside the point.

What we want to do is if any of the cores are stuck - monarch or not -
we want to panic the hell out of this box and not do anything further.
So only the tolerant check would need adjusting.

> I'm OK with it going - but as I said before I'd like to see mce_callin
> printed (so I can tell if just one cpu showed up, just the cpus from
> one socket, or some other significant number).

I don't think you want to do this unconditionally, do you? Rather maybe
mce_timed_out dumps the order variable before the box panics :-)

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/