linux-kernel - Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+8MBb+rqmx+_bL2j6NA2SsGPrVok4xqJqDnjknKupXOgSsJGA@mail.gmail.com>
Date:	Tue, 20 May 2014 10:46:44 -0700
From:	Tony Luck <tony.luck@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Chen Yucong <slaoub@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

On Tue, May 20, 2014 at 3:02 AM, Borislav Petkov <bp@...en8.de> wrote:
>> I'm OK with it going - but as I said before I'd like to see mce_callin
>> printed (so I can tell if just one cpu showed up, just the cpus from
>> one socket, or some other significant number).
>
> I don't think you want to do this unconditionally, do you? Rather maybe
> mce_timed_out dumps the order variable before the box panics :-)

Agreed - not unconditionally - just when we have a problem. Dumping
"order" in the timeout case would be a good place.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/