linux-kernel - Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 May 2014 17:23:03 +0200
From:	Christoph Hellwig <hch@....de>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq
	flush worker

On Tue, May 20, 2014 at 11:20:25AM +0800, Ming Lei wrote:
> - the conflict on the two structures just happens with flush
> requests because rq->requeue_work is only used to queue
> flush requests

Once we get non-trivial block drivers we'll need to be able
to requeue arbitrary requests, that's why I added blk_mq_requeue_request.
The scsi-mq work that I plant to submit for the next merge window is
the prime example.

I'd really prefer to avoid breaking that use case if we can avoid it.

Note that the flush code already is very nasy for blk-mq and this just
makes it worse.

One fix that would also help to sort out some of the flush issues would
be to add a list of requests that need requeueing to the blk_mq context,
which we can add requeusts to from irq context.  The next time we run
hw contexts for the queue we'll pick them up in user context and insert
them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/