linux-kernel - Re: [PATCH v4 1/3] mfd: max8997: use regmap to access registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 May 2014 17:19:02 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Robert Baldyga <r.baldyga@...sung.com>
Cc:	sameo@...ux.intel.com, a.zummo@...ertech.it,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	m.szyprowski@...sung.com, k.kozlowski@...sung.com
Subject: Re: [PATCH v4 1/3] mfd: max8997: use regmap to access registers

> This patch modifies max8997 driver and each associated function driver,
> to use regmap instead of operating directly on i2c bus. It will allow to
> simplify IRQ handling using regmap-irq.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> [For extcon part]
> Acked-by: Chanwoo Choi <cw00.choi@...sung.com>
> 
> [For leds part]
> Acked-by: Bryan Wu <cooloney@...il.com>
> ---
>  drivers/extcon/extcon-max8997.c     |  31 ++++----
>  drivers/input/misc/max8997_haptic.c |  34 +++++----
>  drivers/leds/leds-max8997.c         |  13 ++--
>  drivers/mfd/Kconfig                 |   1 +
>  drivers/mfd/max8997-irq.c           |  64 +++++++---------
>  drivers/mfd/max8997.c               | 141 ++++++++++++++++-------------------

Looks to be doing the right things and the diff looks good.

For the MFD part:
  Acked-by: Lee Jones <lee.jones@...aro.org>

>  drivers/power/max8997_charger.c     |  33 +++++----
>  drivers/regulator/max8997.c         |  87 +++++++++++-----------
>  drivers/rtc/rtc-max8997.c           |  56 +++++++-------
>  include/linux/mfd/max8997-private.h |  17 ++---
>  10 files changed, 228 insertions(+), 249 deletions(-)

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/