linux-kernel - Re: [PATCH] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140521103432.GM2708@katana>
Date:	Wed, 21 May 2014 12:34:32 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
Cc:	linux-i2c@...r.kernel.org, naveenkrishna.ch@...il.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, sjg@...omium.org,
	linux-kernel@...r.kernel.org, cpgs@...sung.com, broonie@...nel.org,
	t.figa@...sung.com
Subject: Re: [PATCH] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

On Mon, Apr 28, 2014 at 02:29:58PM +0530, Naveen Krishna Chatradhi wrote:
> HSI2C module on Exynos5260 differs from current modules in
> following ways:
> 1.  HSI2C on Exynos5260 has fifo_depth of 16bytes
> 2.  Module needs to be reset as a part of init sequence.
> 
> Hence, Following changes are involved.
> 1. Add a new compatible string and Updates the Documentation dt bindings.
> 2. Introduce a variant struct to support the changes in H/W
> 3. Reset the module during init. Thus, bringing the module back
> to default state irrespective of what firmware did with it.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ich.naveen@...sung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> ---

...

> -		fifo_ctl |= HSI2C_RXFIFO_TRIGGER_LEVEL(HSI2C_DEF_TXFIFO_LVL);
> +		trig_lvl = (i2c->msg->len > i2c->variant->fifo_depth) ?
> +			(i2c->variant->fifo_depth * 3/4) : i2c->msg->len;
> +		fifo_ctl |= HSI2C_RXFIFO_TRIGGER_LEVEL(trig_lvl);
> +

Dunno why checkpatch missed the 'space around operator' issue, yet I
fixed it here...

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)