linux-kernel - Re: [PATCH] videobuf2-core: remove duplicated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 May 2014 12:36:28 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	Victor Lambret <victor.lambret.ext@...rot.com>,
	Pawel Osciak <pawel@...iak.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] videobuf2-core: remove duplicated code

Hello,

On 2014-05-21 11:48, Victor Lambret wrote:
> Remove duplicated test of buffer presence at streamon
>
> Signed-off-by: Victor Lambret <victor.lambret.ext@...rot.com>

Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

> ---
>   drivers/media/v4l2-core/videobuf2-core.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index f9059bb..b731b66 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -2067,10 +2067,6 @@ static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
>   		return -EINVAL;
>   	}
>   
> -	if (!q->num_buffers) {
> -		dprintk(1, "streamon: no buffers have been allocated\n");
> -		return -EINVAL;
> -	}
>   	if (q->num_buffers < q->min_buffers_needed) {
>   		dprintk(1, "streamon: need at least %u allocated buffers\n",
>   				q->min_buffers_needed);

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/