linux-kernel - Re: [PATCH V2 3/7] driver/core: cpu: initialize opp table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <537CBB4C.7000006@arm.com>
Date:	Wed, 21 May 2014 15:42:20 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	Sudeep Holla <sudeep.holla@....com>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arvind Chauhan <Arvind.Chauhan@....com>,
	"inderpal.s@...sung.com" <inderpal.s@...sung.com>,
	"nm@...com" <nm@...com>,
	"chander.kashyap@...aro.org" <chander.kashyap@...aro.org>,
	"pavel@....cz" <pavel@....cz>,
	"len.brown@...el.com" <len.brown@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Amit Daniel Kachhap <amit.daniel@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH V2 3/7] driver/core: cpu: initialize opp table



On 21/05/14 15:01, Viresh Kumar wrote:
> On 21 May 2014 19:15, Sudeep Holla <sudeep.holla@....com> wrote:
>> [Nit] Not sure if we need this logging on each cpu, may be dev_dbg if you
>> still
>> fancy one ? :)
>
> It wouldn't happen on each CPU, but one CPU per policy as others
> would return -ENODEV.
>

Hmm agreed, but there are SoCs that support per CPU DVFS ;)

> I added dev_dbg earlier but then I thought dev_info is better as we may
> better show this to everybody as it about the most important device,
> i.e. CPU :)
>
>>> +       /* Print error only if there is an issue with OPP table */
>>> +       else if (error != -ENOSYS && error != -ENODEV)
>>> +               dev_err(&cpu->dev, "%s: failed to init OPP table for
>>> cpu%d, err: %d\n",
>>> +                       __func__, cpu->dev.id, error);
>>> +}
>>> +#else
>>> +static inline void of_init_cpu_opp_table(struct cpu *cpu) {}
>>> +#endif
>>> +
>>
>>
>> IMO this could be more generic and applicable for any device if you replace
>> "struct cpu" with "struct device". I know this is currently used by cpu but
>> we can extend it's use for any device if needed in future. You can then move
>> this to pm_opp.h as of_init_dev_opp_table may be.
>
> Probably we will call of_init_opp_table() directly for other devices, as this
> function doesn't do anything else, apart from some prints.. So, probably
> leave is as is for now, unless a real need arises ?
>

I don't see anything cpu specific there, but that's just my opinion.

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/