lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 May 2014 01:57:29 +0200 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Viresh Kumar <viresh.kumar@...aro.org> Cc: Lists linaro-kernel <linaro-kernel@...ts.linaro.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Arvind Chauhan <arvind.chauhan@....com>, Ips Gandhi <inderpal.s@...sung.com>, Pavel Machek <pavel@....cz>, Nishanth Menon <nm@...com>, Chander Kashyap <chander.kashyap@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Amit Daniel Kachhap <amit.daniel@...sung.com>, Kukjin Kim <kgene.kim@...sung.com>, Shawn Guo <shawn.guo@...aro.org>, Sudeep Holla <sudeep.holla@....com> Subject: Re: [PATCH Resend] driver/core: cpu: initialize opp table On Tuesday, May 20, 2014 08:08:11 AM Viresh Kumar wrote: > On 20 May 2014 02:43, Rafael J. Wysocki <rjw@...ysocki.net> wrote: > > What about > > > > if (error) > > return error; > > > > and then you'd save an indentation level? > > Yes. > > > Anyway, I find adding of_node* stuff directly to the driver core this way > > kind of disgusting as there still are platforms that don't use it. > > > > Can we have a call to a function that will change into an empty stub on such > > platforms here, please? > > Okay. But can you explain a bit more about how and where those stubs > would be implemented? In a header file included by cpu.c. Something like #if defined(CONFIG_OF) && defined(CONFIG_PM_OPP) <function header> #else static inline <stub> #endif -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists