linux-kernel - Re: [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140523101056.GR19747@lee--X1>
Date:	Fri, 23 May 2014 11:10:56 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: db8500-prcmu: remove check for
 CONFIG_DBX500_PRCMU_DEBUG

> A check for CONFIG_DBX500_PRCMU_DEBUG was added in v3.6. But there's no
> Kconfig symbol DBX500_PRCMU_DEBUG. So remove this check.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Untested. Note that db8500_prcmu_debug_dump() is nowhere to be found in
> the tree.
> 
> This check has been in the tree for less than two years. Am I being
> impatient here?
> 
>  drivers/mfd/db8500-prcmu.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index 7694e0700d34..c248bde367ab 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2303,9 +2303,6 @@ int prcmu_ac_wake_req(void)
>  
>  	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
>  			msecs_to_jiffies(5000))) {
> -#if defined(CONFIG_DBX500_PRCMU_DEBUG)
> -		db8500_prcmu_debug_dump(__func__, true, true);
> -#endif
>  		pr_crit("prcmu: %s timed out (5 s) waiting for a reply.\n",
>  			__func__);
>  		ret = -EFAULT;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/