linux-kernel - Re: [PATCH 1/2] ASoC: max98090: Add master clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140523114113.GE12304@sirena.org.uk>
Date:	Fri, 23 May 2014 12:41:13 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	Linux-ALSA <alsa-devel@...a-project.org>,
	lkml <linux-kernel@...r.kernel.org>,
	devicetree <devicetree@...r.kernel.org>,
	Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>,
	Doug Anderson <dianders@...omium.org>,
	"jerry.wong" <jerry.wong@...imintegrated.com>
Subject: Re: [PATCH 1/2] ASoC: max98090: Add master clock handling

On Fri, May 23, 2014 at 05:06:27PM +0530, Tushar Behera wrote:
> On 23 May 2014 16:44, Mark Brown <broonie@...nel.org> wrote:

> > Should be clk_prepare_enable() and similarly for the disable and you
> > should check the error codes but yes, that looks good.

> I was planning to keep clk_prepare/clk_unprepare in probe/remove.

Why - what purpose would it serve to leave the clock prepared but not
enabled?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)